[Top] [All Lists]

Re: [PATCH net-next] bcm63xx_enet: add support Broadcom BCM6345 Ethernet

Subject: Re: [PATCH net-next] bcm63xx_enet: add support Broadcom BCM6345 Ethernet
From: David Miller <>
Date: Thu, 13 Jun 2013 02:25:24 -0700 (PDT)
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <> <> <>
From: Florian Fainelli <>
Date: Thu, 13 Jun 2013 09:58:34 +0100

> 2013/6/13 David Miller <>:
>> From: Florian Fainelli <>
>> Date: Wed, 12 Jun 2013 20:53:05 +0100
>> I want the MIPS folks to fix this brain damange.
>> This runtime detect thing is just a big mess in a header file
>> using hundreds of lines of CPP stuff to express what is fundamentally
>> a simple (albeit sizable) Kconfig dependency.
> The codebase supporting the Broadcom BCM63xx SoC supports about 6-7

You don't need to explain it to me, I read the code and understand
what it's trying to accomplish.

I reject the implementation of it, only.

> No, the ifdefs are kept in the arch/mips/bcm63xx portions of the code
> specifically for that reason. The driver just needs to take into account a
> new set of platform_data properties to deal with this.

Fine, it's still terrible.

<Prev in Thread] Current Thread [Next in Thread>