[Top] [All Lists]

RE: [PATCH v2 1/2] usb: chipidea: big-endian support

To: Svetoslav Neykov <>, 'Michael Grzeschik' <>
Subject: RE: [PATCH v2 1/2] usb: chipidea: big-endian support
From: Alexander Shishkin <>
Date: Fri, 29 Mar 2013 16:58:40 +0200
Cc: 'Ralf Baechle' <>, 'Greg Kroah-Hartman' <>, 'Gabor Juhos' <>, 'John Crispin' <>, 'Alan Stern' <>, "'Luis R. Rodriguez'" <>,,
In-reply-to: <023101ce2bfb$712ea0f0$538be2d0$>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
References: <> <> <> <> <023101ce2bfb$712ea0f0$538be2d0$>
User-agent: Notmuch/0.12+187~ga2502b0 ( Emacs/23.4.1 (x86_64-pc-linux-gnu)
Svetoslav Neykov <> writes:

> Hi Michael,
> On Thu, March 28, 2013 4:13 PM Michael Grzeschik wrote: 
>>On Thu, Mar 28, 2013 at 11:28:32AM +0200, Alexander Shishkin wrote:
>>> Svetoslav Neykov <> writes:
>>> > Convert between big-endian and little-endian format when accessing the
> usb controller structures which are little-endian by specification.
>>> > Fix cases where the little-endian memory layout is taken for granted.
>>> > The patch doesn't have any effect on the already supported
>>> > little-endian architectures.
>>> Applied to my branch of things that are aiming at v3.10. Next time
>>> please make sure that it applies cleanly.
>>I am currently rebasing my fix/cleanup/feature patches against your
>>ci-for-greg and realised that this patch missed to fix debug.c with
>>cpu_le_32 action. Is someone volunteering to cook a patch?
> I will gladly make the changes, but after having a look at it I didn't spot
> any candidates. The DMA buffers are printed either as addresses in memory or
> as raw data which doesn't make sense to be cpu_le_32'ed. If Alexander hasn't
> already made the changes could you point me to the lines in question.

You're right, it's either physical addresses or raw data, no need for
conversions there.


<Prev in Thread] Current Thread [Next in Thread>