[Top] [All Lists]

Re: [PATCH] mips: remove unecessary __linux__ check

To: liguang <>
Subject: Re: [PATCH] mips: remove unecessary __linux__ check
From: Ralf Baechle <>
Date: Tue, 19 Feb 2013 11:04:25 +0100
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
References: <>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Feb 19, 2013 at 04:12:51PM +0800, liguang wrote:

> sgidefs.h has strict check for __linux__,
> it seems too harsh, as far as I test, 2 cross
> compiler for mips will not define it automatically,
> and exit build process with error
> "#error Use a Linux compiler or give up".
> remove it will not hurt, I think.

My mailbox used to get flooded by people who attempted to build a kernel
using something like a mips-elf, mips-sde-elf or even stranger targets.
There are further differences than just the definition of __linux__ so
I eventually applied this check.


<Prev in Thread] Current Thread [Next in Thread>