[Top] [All Lists]

Re: [PATCH] mips: Move __virt_addr_valid() to a place for MIPS 64

To: Steven Rostedt <>
Subject: Re: [PATCH] mips: Move __virt_addr_valid() to a place for MIPS 64
From: Aaro Koskinen <>
Date: Sat, 26 Jan 2013 22:15:41 +0200
Cc: LKML <>, linux-mips <>, Ralf Baechle <>
In-reply-to: <1359137595.21576.246.camel@gandalf.local.home>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
References: <1359137595.21576.246.camel@gandalf.local.home>
User-agent: Mutt/1.5.21 (2010-09-15)

On Fri, Jan 25, 2013 at 01:13:15PM -0500, Steven Rostedt wrote:
> Commit d3ce88431892 "MIPS: Fix modpost error in modules attepting to use
> virt_addr_valid()" moved __virt_addr_valid() from a macro in a header
> file to a function in ioremap.c. But ioremap.c is only compiled for MIPS
> 32, and not for MIPS 64.
> When compiling for my yeeloong2, which supposedly supports hibernation,
> which compiles kernel/power/snapshot.c which calls virt_addr_valid(), I
> got this error:

This has been reported also here:

and here:

It's pretty sad that MIPS has been pretty much broken during the whole
3.8-rc cycle. :-(


<Prev in Thread] Current Thread [Next in Thread>