[Top] [All Lists]

Re: [PATCH v2 0/3] MIPS: JZ4740: Move PWM driver to PWM framework

To: Lars-Peter Clausen <>
Subject: Re: [PATCH v2 0/3] MIPS: JZ4740: Move PWM driver to PWM framework
From: Thierry Reding <>
Date: Mon, 10 Sep 2012 19:30:56 +0200
Cc: Ralf Baechle <>,,, Antony Pavlov <>, Maarten ter Huurne <>
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
References: <> <>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Sep 10, 2012 at 05:20:34PM +0200, Lars-Peter Clausen wrote:
> On 09/10/2012 02:05 PM, Thierry Reding wrote:
> > Hi,
> > 
> I think v2 looks, good. Will give it some testing later.
> > This small series fixes a build error due to a circular header
> > dependency, exports the timer API so it can be used outside of
> > the arch/mips/jz4740 tree and finally moves and converts the
> > JZ4740 PWM driver to the PWM framework.
> > 
> > Note that I don't have any hardware to test this on, so I had to
> > rely on compile tests only. Patches 1 and 2 should probably go
> > through the MIPS tree, while I can take patch 3 through the PWM
> > tree. It touches a couple of files in arch/mips but the changes
> > are unlikely to cause conflicts.
> Patch 2 and 3 should probably go through the same tree since patch 3 depends
> on patch 2. I'd like to see them both go through the PWM tree.

That's fine with me. I'll probably need an Acked-by from Ralf just to be

> Patch 1 should go through the MIPS tree, but I still can't see why the issue
> should occur nor does it happen for anybody else except for you. Instead of
> moving the content over to the public irq.h I'd rather like to see the
> private irq.h being renamed.

If we can solve this some other way I'm all for it. Maybe you can share
the defconfig or .config that you use so I can test under the same


Attachment: pgpEFEdGlB5yC.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>