[Top] [All Lists]

Re: [PATCH 1/3] MIPS: JZ4740: Break circular header dependency

To: Lars-Peter Clausen <>
Subject: Re: [PATCH 1/3] MIPS: JZ4740: Break circular header dependency
From: Thierry Reding <>
Date: Sun, 2 Sep 2012 21:16:55 +0200
Cc: Ralf Baechle <>,,, Antony Pavlov <>, Maarten ter Huurne <>
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
References: <> <> <>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sun, Sep 02, 2012 at 04:48:46PM +0200, Lars-Peter Clausen wrote:
> On 09/02/2012 11:52 AM, Thierry Reding wrote:
> > When including irq.h, arch/mips/jz4740/irq.h will be selected as the
> > first candidate. This header does not include the proper definitions
> > (most notably NR_IRQS) required by subsequent headers. To solve this
> > arch/mips/jz4740/irq.h can be deleted and its contents can be moved
> > into arch/mips/include/asm/mach-jz4740/irq.h, which will then be
> > correctly included.
> > 
> Where exactly did you have this problem? arch/mips/jz4740/ should not be in 
> the
> include path, so "#include <irq.h>" should not cause arch/mips/jz4740/irq.h to
> be included.

While compile-testing I did make ARCH=mips menuconfig and selected
JZ4740 plus the new PWM driver option, then ran make ARCH=mips. That
showed errors like struct irq_data not being declared or NR_IRQS not
being defined. Maybe I was just using a very strange configuration.

I tested this with 3.6-rc3 and linux-next, both had this problem.
Neither of them had a default configuration for JZ4740, so maybe I'm
just missing a configuration option.


Attachment: pgpq4Ycq65PcP.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>