[Top] [All Lists]

Re: [PATCH V2 1/2] asm-offsets.c: adding #define to break circular depen

To: Jim Quinlan <>,
Subject: Re: [PATCH V2 1/2] asm-offsets.c: adding #define to break circular dependency
From: David Daney <>
Date: Wed, 29 Aug 2012 16:01:58 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=Y/LVngYRWoXnWo/P7NMj7nHubXXLOKpcgAbKu5NtL/M=; b=o05YYJgySRdVq3JrIMxwb8u7A23TH+JhJvtDId3rT9aV2//f56MeoWwvRoVJMWCLgc vW1ca5zSIBSHLtdfnpj9TMtK1vaMsuT/pHrErG8h/jldb+Q+1S3j3EtFOTTF/1e1DXv7 gPhNE+/pCaMEZ6m8fbKbYtZTFGrDm0+Ja9h8d+/S80V4v+WTIWrWNM7PHk+v9nWPUWhx dSUB2AFbbgidzThfcXppSeI8Nc2FlFoj5911L8D73/JFCFXcgDVEDYqoWkkAv6yUOXf6 U4Li8TKr3rRA8kfgxNGQfXpZnM6DCCV6rNKOlFFlk2tx6tBZWqNT+aK3Rc1LxovHKqD3 zqZg==
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
References: <y> <>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0
On 08/29/2012 03:34 PM, Jim Quinlan wrote:
irqflags.h depends on asm-offsets.h, but asm-offsets.h depends
on irqflags.h when generating asm-offsets.h.

What is there in irqflags.h that is required by asm-offsets.c?

Why can't the include tangle be undone so that that part can be factored out to a separate file?

Adding a definition
to the top of asm-offsets.c allows us to break this circle.  There
is a similar define in bounds.c

Signed-off-by: Jim Quinlan <>
  arch/mips/kernel/asm-offsets.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/mips/kernel/asm-offsets.c b/arch/mips/kernel/asm-offsets.c
index 6b30fb2..035f167 100644
--- a/arch/mips/kernel/asm-offsets.c
+++ b/arch/mips/kernel/asm-offsets.c
@@ -8,6 +8,7 @@
   * Kevin Kissell, and Carsten Langgaard,
   * Copyright (C) 2000 MIPS Technologies, Inc.
  #include <linux/compat.h>
  #include <linux/types.h>
  #include <linux/sched.h>

<Prev in Thread] Current Thread [Next in Thread>