[Top] [All Lists]

Re: [PATCH V7 2/4] MIPS: Add board support for Loongson1B

To: Florian Fainelli <>
Subject: Re: [PATCH V7 2/4] MIPS: Add board support for Loongson1B
From: Ralf Baechle <>
Date: Thu, 21 Jun 2012 12:32:34 +0100
Cc: Sergei Shtylyov <>, Kelvin Cheung <>,,,,
In-reply-to: <1463808.aB2kcWCEuH@bender>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
References: <> <> <> <1463808.aB2kcWCEuH@bender>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jun 20, 2012 at 10:10:26PM +0200, Florian Fainelli wrote:

> > > This redefines a function that already is declared in <linux/clk.h> and
> > > defined in drivers/clk/clkdev.c.  Why?
> > 
> >     Because he doesn't support clkdev? clkdev support is optional.
> I don't think it is a good idea not to support clkdev for new targets. Ralf 
> what do you think about it?

My gut feeling is that if there's a suitable generic infrastructure we
should use it, so use clkdev for new targets.  I was just wondering if
there's a good reason to doing things the way he did.


<Prev in Thread] Current Thread [Next in Thread>