[Top] [All Lists]

Re: [PATCH] irq/irq_domain: Quit ignoring error returns from irq_alloc_d

To: Rob Herring <>
Subject: Re: [PATCH] irq/irq_domain: Quit ignoring error returns from irq_alloc_desc_from().
From: David Daney <>
Date: Mon, 09 Apr 2012 09:52:27 -0700
Cc: Grant Likely <>, Benjamin Herrenschmidt <>, Thomas Gleixner <>,,,
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=Or3FR2dj3bWcMvWyhodj0Otlmnm+BD8D3wDpNWxeEMo=; b=kyUT25VaIjMGkCBZfagNq5pSHrzpnYp/8YdBaMH+RAlpwYz3diRNaOKkotTs/kWoRm X/yAUn+uY7yhwvwhePP1PhZhSuLU9KpYK2cqt1NEsWFd4uLy1uFhHPy9rRoneWDQf5z3 TkUQu7W8pDKxFST1BxAh4BRo8Y2fsTuHAmcgDCs0dTL3t7+z7vIW+77xrQKsmviRjJj/ a/YwrPQeydakutjNa5uM/lARdzSLFTxfQ20i+cOJ8DqCQCCaSSHSGm9XrZxDDUBMp6j+ LEX6KxdN02eYOaHT6SogG/eFl5eoIdLfEVNMLVhXHv9KLmx7WVMpo4yOMKxjYCUZnRAw FRbQ==
In-reply-to: <20120406235607.DCCD53E15E9@localhost>
References: <> <> <> <20120406235607.DCCD53E15E9@localhost>
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10
On 04/06/2012 04:56 PM, Grant Likely wrote:
On Fri, 06 Apr 2012 09:37:49 -0700, David Daney<>  wrote:
On 04/05/2012 08:37 PM, Rob Herring wrote:
On 04/05/2012 06:52 PM, David Daney wrote:
From: David Daney<>
@@ -380,14 +381,14 @@ unsigned int irq_create_mapping(struct irq_domain *domain,
        hint = hwirq % irq_virq_count;
        if (hint == 0)
-       virq = irq_alloc_desc_from(hint, 0);

You are not looking at mainline. hint was removed in later versions, and
the referenced commit ids don't exist.

Please look at Linus' tree before making incorrect statements about
whether or not code exists on the 'mainline'

Rob is indeed mistaken here, but please let's keep things civil.

Sorry about that.  You are correct that it is not acceptable.

David Daney

<Prev in Thread] Current Thread [Next in Thread>