[Top] [All Lists]

Re: [PATCH 00/12] Part 2: check given MAC address, if invalid return -EA

To: Michał Mirosław <>
Subject: Re: [PATCH 00/12] Part 2: check given MAC address, if invalid return -EADDRNOTAVAIL
From: Geert Uytterhoeven <>
Date: Sat, 25 Feb 2012 11:13:21 +0100
Authentication-results:; spf=pass ( domain of designates as permitted sender); dkim=pass
Cc: Danny Kukawka <>, "David S. Miller" <>, Andy Gospodarek <>, Guo-Fu Tseng <>, Petko Manolov <>, "VMware, Inc." <>, "John W. Linville" <>,, Mauro Carvalho Chehab <>, Danny Kukawka <>, Stephen Hemminger <>, Joe Perches <>, Jeff Kirsher <>, Jiri Pirko <>,,,,,,,,,
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=FTo18kF83qd2ZDn8e2WM7/LVC5vCM7flxBkElmQKbL8=; b=Djb2cvWHDr0mB1R9I+E5VZYKvIB1jhAn+WYu1c3XJDMw1IizIe7b4ll5OhMRby8JUU RqKUYTXnDaqc6RjUbI1of85kTEaojeRmtzlASrjpv/8Oq+VEGxg20av4A+Dm+POK4yiH y/ZAd5eHhD/tB5D1BE88VS3R7aFvoe99lMeN8=
In-reply-to: <>
References: <> <>
2012/2/24 Michał Mirosław <>:
> 2012/2/24 Danny Kukawka <>:
>> Second Part of series patches to unifiy the return value of
>> .ndo_set_mac_address if the given address isn't valid.
>> These changes check if a given (MAC) address is valid in
>> .ndo_set_mac_address, if invalid return -EADDRNOTAVAIL
>> as eth_mac_addr() already does if is_valid_ether_addr() fails.
> Why not just fix dev_set_mac_address() and make do_setlink() use that?

BTW, it's also called from dev_set_mac_address().

> Checks are specific to address family, not device model I assume.

Indeed, why can't this be done in one single place, instead of sprinkling these
checks over all drivers, missing all out-of-tree (note: I don't care) and all
soon-to-be-submitted drivers?



Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

<Prev in Thread] Current Thread [Next in Thread>