[Top] [All Lists]

Re: [PATCH 00/12] Part 2: check given MAC address, if invalid return -EA

To: Danny Kukawka <>
Subject: Re: [PATCH 00/12] Part 2: check given MAC address, if invalid return -EADDRNOTAVAIL
From: Michał Mirosław <>
Date: Fri, 24 Feb 2012 18:59:04 +0100
Authentication-results:; spf=pass ( domain of designates as permitted sender); dkim=pass
Cc: "David S. Miller" <>, Andy Gospodarek <>, Guo-Fu Tseng <>, Petko Manolov <>, "VMware, Inc." <>, "John W. Linville" <>,, Mauro Carvalho Chehab <>, Danny Kukawka <>, Stephen Hemminger <>, Joe Perches <>, Jeff Kirsher <>, Jiri Pirko <>,,,,,,,,,
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=HNn6H3hm4G/LuHJaxW51hiS54zqmUVFTWgoL8/Qwmp4=; b=uRweyO3pqeGxoxfdvseACLmdNBChiN19x/DDO3lfFzzkC4EHvlfgZClu3ED0MUHxSt 7crUfxu+uCPklEWZyUG9PVSYoVFz+4VfaBNEvTnjnXQgxZ7lplyVpX11gTcRpx5wNKLh TWLgXo2nKR4va2ROXG7Wd2IGRwoVUEpPi/2uc=
In-reply-to: <>
References: <>
2012/2/24 Danny Kukawka <>:
> Second Part of series patches to unifiy the return value of
> .ndo_set_mac_address if the given address isn't valid.
> These changes check if a given (MAC) address is valid in
> .ndo_set_mac_address, if invalid return -EADDRNOTAVAIL
> as eth_mac_addr() already does if is_valid_ether_addr() fails.

Why not just fix dev_set_mac_address() and make do_setlink() use that?
Checks are specific to address family, not device model I assume.

Best Regards,
Michał Mirosław

<Prev in Thread] Current Thread [Next in Thread>