[Top] [All Lists]

Re: [PATCH] staging/octeon: Fix PHY binding in octeon-ethernet driver.

To: David Daney <>
Subject: Re: [PATCH] staging/octeon: Fix PHY binding in octeon-ethernet driver.
From: Florian Fainelli <>
Date: Fri, 24 Feb 2012 10:29:33 +0100
Authentication-results:; spf=pass ( domain of designates as permitted sender); dkim=pass
Cc: Greg Kroah-Hartman <>,,, David Daney <>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=gamma; h=sender:message-id:date:from:organization:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=MYC//gsSD5oSZl9SlBNK5sxc0DL3iqXGDaqao88MkT0=; b=lJ+17O88iRFsAiMWlPeeUjdxqmcosG8o2XweR3hCwnQ1aMXqlRBAoiF7GvzgfsUGzo q4bcpoa7xgoG2wFpSkCCTReFx8qLEDwru4HgF6klxOGLmIqkIuRwNAYeoi7tuuHdExUP fGI/9zWJ/tOms+2ZEUyHwdLEtnIJ9ZkJdrbHs=
In-reply-to: <>
Organization: OpenWrt
References: <>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2
Le 02/23/12 20:19, David Daney a écrit :
From: David Daney<>

Commit d6c25be (mdio-octeon: use an unique MDIO bus name.) changed the
names used to refer to MDIO buses.  The ethernet driver must be
changed to match, so that the PHY drivers can be attached.

Cc: Florian Fainelli<>
Signed-off-by: David Daney<>
Acked-by: Florian Fainelli <>
  drivers/staging/octeon/ethernet-mdio.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/octeon/ethernet-mdio.c 
index 63800ba..e31949c 100644
--- a/drivers/staging/octeon/ethernet-mdio.c
+++ b/drivers/staging/octeon/ethernet-mdio.c
@@ -164,9 +164,9 @@ int cvm_oct_phy_setup_device(struct net_device *dev)

        int phy_addr = cvmx_helper_board_get_mii_address(priv->port);
        if (phy_addr != -1) {
-               char phy_id[20];
+               char phy_id[MII_BUS_ID_SIZE + 3];

-               snprintf(phy_id, sizeof(phy_id), PHY_ID_FMT, "0", phy_addr);
+               snprintf(phy_id, sizeof(phy_id), PHY_ID_FMT, "mdio-octeon-0", 

                priv->phydev = phy_connect(dev, phy_id, cvm_oct_adjust_link, 0,

<Prev in Thread] Current Thread [Next in Thread>