|To:||John Crispin <firstname.lastname@example.org>|
|Subject:||Re: [PATCH 7/9] SERIAL: MIPS: lantiq: convert serial driver to clkdev api|
|From:||Sergei Shtylyov <email@example.com>|
|Date:||Fri, 17 Feb 2012 20:53:39 +0300|
|Cc:||Ralf Baechle <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org|
|References:||<email@example.com> <firstname.lastname@example.org> <4F3E90C4.email@example.com> <4F3E84B3.firstname.lastname@example.org>|
|User-agent:||Mozilla/5.0 (X11; Linux i686; rv:10.0.1) Gecko/20120208 Thunderbird/10.0.1|
Hello. On 02/17/2012 07:47 PM, John Crispin wrote:
The comment doesn't match the essence of patch.
Why not just clk_get(&pdev->dev, NULL)?
clk_get_sys uses the clkdev lookup table, which is added by this series.
clk_get() does the same, indirectly.
it makes the clock code consistent throughout the lantiq related files. we use clk connections other places, which we cannot reference with clk_get that easily
clkdev assumes you don't need to use connection ID if the clock is bound to be matched by device ID via the lookup table. clk_get() is a common case when using clkdev, that's why your use of clk_get_sys() stands out as something unusual. I'll have to have a look at your lookup tables...
|<Prev in Thread]||Current Thread||[Next in Thread>|
|Previous by Date:||Re: [PATCH 2/3] MIPS: lantiq: add vr9 support, John Crispin|
|Next by Date:||Stack unwind across signal frame, Alan Cooper|
|Previous by Thread:||Re: [PATCH 7/9] SERIAL: MIPS: lantiq: convert serial driver to clkdev api, John Crispin|
|Next by Thread:||[PATCH 8/9] NET: MIPS: lantiq: convert etop driver to clkdev api, John Crispin|
|Indexes:||[Date] [Thread] [Top] [All Lists]|