[Top] [All Lists]

Re: [PATCH] net: meth: Add set_rx_mode hook to fix ICMPv6 neighbor disco

To: David Miller <>
Subject: Re: [PATCH] net: meth: Add set_rx_mode hook to fix ICMPv6 neighbor discovery
From: Joshua Kinard <>
Date: Sun, 18 Dec 2011 09:40:24 -0500
In-reply-to: <>
References: <> <> <> <>
User-agent: Mozilla/5.0 (Windows NT 6.0; WOW64; rv:8.0) Gecko/20111105 Thunderbird/8.0
On 12/18/2011 00:19, David Miller wrote:

> From: Joshua Kinard <>
> Date: Sat, 17 Dec 2011 23:37:01 -0500
>> MACE Ethernet only ever appears on the SGI O2 systems.
> That has no bearing on my feedback, we simply do not put non-portable
> code like this into the tree at this point.
> Just because this driver has been maintained in an non-portable manner
> up to this point, doesn't mean we continue doing that.

Agreed.  However, I was simply trying to fix a problem that prevents IPv6
from working, not fix every little thing wrong with the code.  While I want
to tackle re-writing the driver to be more in line with existing network
drivers, that's a future project.  I'm still new to driver
development/kernel work in general, so I'm learning here.

Thanks for the feedback, though,

Joshua Kinard
4096R/D25D95E3 2011-03-28

"The past tempts us, the present confuses us, the future frightens us.  And
our lives slip away, moment by moment, lost in that vast, terrible in-between."

--Emperor Turhan, Centauri Republic

<Prev in Thread] Current Thread [Next in Thread>