[Top] [All Lists]

Re: [Patch v2]: Fix ld pr11138 FAILures on mips*.

To: David Daney <>
Subject: Re: [Patch v2]: Fix ld pr11138 FAILures on mips*.
From: Richard Sandiford <>
Date: Sat, 10 Dec 2011 10:19:20 +0000
Cc: binutils <>, Alan Modra <>, Manuel Lauss <>, Debian MIPS <>, linux-mips <>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=gamma; h=from:to:mail-followup-to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=FUD905LAPgordNukFEaefCmiCijTYj0y1kkzl0Abv38=; b=SH3ENlZ4Nzcy83AihLeoZx8iPAPoghL0CZrWo1WtirwXUc7UYYpnLjYUgpN/AdQb/G 6OOSA+Q92FG4b9ChYKSHzvnAIDu3yKCl2cTDN5nj8EwpvWOTItF8i8uhuteuVFOXIzAv p4WUOnUj6zF6VBZX4wnoXCYNcSoyoeIvoaLm0=
In-reply-to: <> (David Daney's message of "Fri, 09 Dec 2011 16:50:01 -0800")
Mail-followup-to: David Daney <>,binutils <>, Alan Modra <>, Manuel Lauss <>, Debian MIPS <>, linux-mips <>,
References: <> <> <>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
David Daney <> writes:
> I will wait a couple of days to give Richard a chance to object.

Looks good to me too.  Thanks for doing this.  I think it should go
on the 2.22 branch as well.

> I am especially concerned about what happens on IRIX where the symbol
> comes in from an external object rather than being generated by the
> linker itself.  I had no way to test that.

Me neither, unfortunately.  But I agree it looks right.  There's a
possibility that we could create the dynamic sections before the
definition of __rld_obj_head has been read in (e.g. from the
check_relocs of a previous object).  In that case it looks like
we would create the .rld_map section and __rld_map/__RLD_MAP symbol,
then later switch to __rld_obj_head.  .rld_map would then be left
at zero size and the __rld_map/__RLD_MAP symbol would be ignored
when setting the tag value.  But your patch preserves the
behaviour in that case too.


<Prev in Thread] Current Thread [Next in Thread>