[Top] [All Lists]

Re: [PATCH 12/12] MIPS: Netlogic: Mark Netlogic chips as SMT capable

To: Hillf Danton <>
Subject: Re: [PATCH 12/12] MIPS: Netlogic: Mark Netlogic chips as SMT capable
From: Ralf Baechle <>
Date: Fri, 11 Nov 2011 13:49:06 +0000
Cc:, "Jayachandran C." <>
In-reply-to: <>
References: <> <> <> <>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Nov 11, 2011 at 09:39:00PM +0800, Hillf Danton wrote:

> The patch was delivered by me, and reprepared under ideas and comments from
> you and Jayachandran, thanks. It was fine tuned, and SOB, by Jayachandran, and
> included in this patchset, which is far beyond my capability, for supporting
> Netlogic chips. And please reconsider the patchset.

This was just a comment on the mechanics of sending patches, not a review
of the patch itself - in fact I think it's fine.

What seems to have happened is that Jayachandran prepared the patches
with git-format-patch, then sent them out using mutt -H, not as the
authors of git had intended using git-send-email.  Git-send-email
puts the sender's email address into the from header and inserts a From:
into the first line of the body, where needed.

On the receiving side it doesn't change a thing - the patch would have
looked exactly the same after being applied to git but as elaborated
before, there are other problems.


<Prev in Thread] Current Thread [Next in Thread>