[Top] [All Lists]

Re: [RESEND PATCH v3 0/2] Pass resources to pci_create_bus() and fix MIP

To: Deng-Cheng Zhu <>
Subject: Re: [RESEND PATCH v3 0/2] Pass resources to pci_create_bus() and fix MIPS PCI resources
From: Bjorn Helgaas <>
Date: Mon, 10 Oct 2011 15:04:21 -0600
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed;; s=beta; t=1318280689; bh=Dwn+kl1Tk6Bf88ymwpRNAT6hxmw=; h=MIME-Version:In-Reply-To:References:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=LSoh9nbvTCl59gYlRyrIg6kZHrf+LNU5VvAxt1rEdo7VCMuMF3Q9vCrqIm4igE6sM baUAzNhZ89D2/6PnSC2Ig==
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=beta; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=IpgDZtq0dWRgFvKP1adf+T78a5+sXS5C1Q3chCXse8U=; b=sQN4sv3WuabhbKVuirZgGh+l8vxHqDMgyYPEoM3ASRw38jvo0hCb6gKXXAtC15hPL9 R+bjQDhkhBGMECFK6B6w==
Domainkey-signature: a=rsa-sha1; s=beta;; c=nofws; q=dns; h=dkim-signature:mime-version:in-reply-to:references:from:date: message-id:subject:to:cc:content-type:x-system-of-record; b=uLZtfZzHecsL4YNJSFoWi65OSfxRKSbFAJBhJeD/1uSJ/XNegnAAEF2+sYQcmWH+h FrrEq48bZy099FXyg9K5g==
In-reply-to: <>
References: <> <>
On Fri, Oct 7, 2011 at 3:50 PM, Bjorn Helgaas <> wrote:
> On Wed, Aug 31, 2011 at 8:48 PM, Deng-Cheng Zhu <> wrote:
>> (Resending the patch set to include more arch maintainers.)
>> Change the pci_create_bus() interface to pass in available resources to get 
>> them
>> settled down early. This is to avoid possible resource conflicts while doing
>> pci_scan_slot() in pci_scan_child_bus(). Note that pcibios_fixup_bus() can 
>> get
>> rid of such conflicts, but it's done AFTER scanning slots.
>> In addition, MIPS PCI resources are now fixed using this new interface.
> Jesse, I assume these are headed for the 3.2 merge window, right?

I tried to build on these patches to convert x86 to using the new
pci_create_bus() interface, but I couldn't figure out a nice way to
handle an arbitrary number of resources.

We made pci_create_bus() take a "struct pci_bus_resource *"

    struct pci_bus *pci_create_bus(struct device *parent, int bus,
                               struct pci_ops *ops, void *sysdata,
                               struct pci_bus_resource *bus_res);

Where pci_bus_resource looks like this:

    struct pci_bus_resource {
        struct list_head list;
        struct resource *res;
        unsigned int flags;

Conceptually, we're passing a list of resources to pci_create_bus(),
which I think is the right thing.  But I think the best way to do that
is by passing a pointer to a struct list_head, not a pointer to a

If we pass a pci_bus_resource, we're basically using that as a
container for a list (as per include/linux/list.h), but it's not a
well-formed list.  Normally a list contains one list_head per element,
plus an extra list_head for the head of the list.  There's a nice
drawing on page 296 of

The list built in your MIPS patch (
consists of two pci_bus_resource structs (each with a list_head), but
there's no third list_head for the head of the list.  I think if you
tried to use list_for_each_entry() to iterate through the list, it
would not work correctly.

I'll post a slightly modified series to show what I mean.  Take a look
and see if it makes sense to you.


<Prev in Thread] Current Thread [Next in Thread>