[Top] [All Lists]

Re: [PATCH 1/4] MIPS: Replace _PAGE_READ with _PAGE_NO_READ

To: Kevin Cernekee <>
Subject: Re: [PATCH 1/4] MIPS: Replace _PAGE_READ with _PAGE_NO_READ
From: David Daney <>
Date: Mon, 18 Apr 2011 10:32:54 -0700
Cc: Ralf Baechle <>,,
In-reply-to: <7aa38c32b7748a95e814e5bb0583f967@localhost>
Original-recipient: rfc822;
References: <7aa38c32b7748a95e814e5bb0583f967@localhost>
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10
On 04/16/2011 09:44 AM, Kevin Cernekee wrote:
Reuse more of the same definitions for the non-RIXI and RIXI cases.  This
avoids having special cases for kernel_uses_smartmips_rixi cluttering up
the pgtable*.h files.

On hardware that does not support RI/XI, EntryLo bits 31:30 / 63:62 will
remain unset and RI/XI permissions will not be enforced.

Signed-off-by: Kevin Cernekee<>
  arch/mips/include/asm/pgtable-bits.h |   23 ++++++++---------------
  arch/mips/include/asm/pgtable.h      |   21 ++++++++-------------
  arch/mips/mm/tlbex.c                 |   17 +++++------------
  3 files changed, 21 insertions(+), 40 deletions(-)


I like this patch.

How much testing have you done on non-RI/XI CPUs?

David Daney

<Prev in Thread] Current Thread [Next in Thread>