[Top] [All Lists]

Re: [PATCH V2 2/2] MSP onchip root hub over current quirk.

To: Anoop P A <>
Subject: Re: [PATCH V2 2/2] MSP onchip root hub over current quirk.
From: Alan Stern <>
Date: Thu, 23 Dec 2010 11:08:36 -0500 (EST)
Cc: Ralf Baechle <>, Greg Kroah-Hartman <>, Anatolij Gustschin <>, Anand Gadiyar <>, <>, <>, <>, Sarah Sharp <>, Oliver Neukum <>, Hans de Goede <>, Paul Mortier <>, Andiry Xu <>
In-reply-to: <1293096541.27661.46.camel@paanoop1-desktop>
Original-recipient: rfc822;
On Thu, 23 Dec 2010, Anoop P A wrote:

> > > +                         usb_detect_quirks(hdev);
> > 
> > This line is wrong.  usb_detect_quirks() gets called only once per 
> > device, when the device is initialized.  Besides, you probably want to 
> > use a hub-specific flag for this rather than a device-specific flag.
> Can you point me to an example for the recommended way of doing the
> hack. I don't have much exposure to USB subsystem.

One example, suitable for PCI devices, can be found in 

However the best approach would be for you to avoid adding any
special-purpose code at all.  Is it possible to handle
overcurrent-change events in a way that will work just as well for
normal hubs as for your MSP root hub?

Alan Stern

<Prev in Thread] Current Thread [Next in Thread>