[Top] [All Lists]

[RFC 0/2] Fixes the modules support of dynamic function tracer for MIPS

Subject: [RFC 0/2] Fixes the modules support of dynamic function tracer for MIPS
From: Wu Zhangjin <>
Date: Sat, 23 Oct 2010 04:58:01 +0800
Cc: David Daney <>,, Wu Zhangjin <>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer; bh=77qy4QhYDMfVfPtNWY9GNkHmW+WmzJ7Rrfo8GZEu41k=; b=VuJlHq8kyVMc9LabnPZoTP3y8tFbtu9r0pPkto/xoqkai+WdrPw8Unj7fF6CTqdzUd 5lrVaRcNPxIhQXeqQMsEkFY5d0MbfhtyQ9HWDyIxOL0ZRioyK66QaMRDQAvYjGnpQXop O46pfy6ffk+VImKsgLmXrAs403VlwtqJ6CUbU=
Domainkey-signature: a=rsa-sha1; c=nofws;; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=NhVo/Tf61c7UCiMrNYzHS7gi7Xo5NjMPRbiPlaGFpLodCwVVMz1GShWKpg8mMkaQaL fTUliiCx0xlOrkll/m8n+hBJzhG8rEiKZ7+cARC19FyTJnYuFmpVzJ4RMHb5S83P2rFF n8MZ5UOROu6nsk4u1F4fR9GYjfqmI+bfzB1n4=
Original-recipient: rfc822;
From: Wu Zhangjin <>

Hi, all

Currently, our in_module() defined in arch/mips/kernel/ftrace.c and
scripts/ for MIPS only considers the module and the core kernel
have different address space and long call is assumed to be used.

But as David pointed before, the module may be in the same space as the core
kernel, therefore, with the current implementation, dynamic function tracer for
MIPS will not work for that situation.

This patchset is created to fix it.

As we know, to jump from an address to _mcount, for _mcount is in kernel space,
if the address is also in kernel space, then, no long call is needed(for the
"jal" can jump to a place whose offset is smaller than 2^28=256MB and
no kernel image is possible to be bigger than 256MB), otherwise, (only
consider the address passed by ftrace_make_{nop,call}), to jump from
the address to _mcount, long call via "jalr" is needed:

if (in_kernel_space(addr)) {
        jal _mcount;
} else {
        load the address of _mcount to a register
        jalr <register>

Now, after implementing in_kernel_space() in the 1st patch, that
situation(module and core kernel are in the same address space) is also covered.

But the 1st patch is not enough to fix the whole problem, we also need to
record the right calling site(for long call, not really the calling site, but
the position for loading the address to the register) for the module in that
situation. Because no long call is needed for that situation, to get the
calling site to _mcount, we need to search the R_MIPS_26 like the kernel, the
2nd patch does it.

        Wu Zhangjin

Wu Zhangjin (2):
  MIPS: tracing/ftrace: Replace in_module() with a generic
  MIPS: tracing/ftrace: Fixes mcount_regex for modules

 arch/mips/kernel/ftrace.c |   66 ++++++++++++++++++++++++--------------------
 scripts/   |   46 +++++++++++++++++++-----------
 2 files changed, 65 insertions(+), 47 deletions(-)

<Prev in Thread] Current Thread [Next in Thread>