[Top] [All Lists]

Re: [PATCH] of/mips: Cleanup some include directives/files.

To: David Daney <>
Subject: Re: [PATCH] of/mips: Cleanup some include directives/files.
From: Ralf Baechle <>
Date: Wed, 20 Oct 2010 07:58:30 +0100
Cc:,,,, Dezhong Diao <>
In-reply-to: <>
Original-recipient: rfc822;
References: <>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Oct 19, 2010 at 03:50:31PM -0700, David Daney wrote:

> The __init directives should go on the definitions of things, not the
> declaration, also __init is meaningless for inline functions, so
> remove it from prom.h.  This allows us to get rid of a useless
> #include, but most of the rest of them are useless too, so kill them
> as well.
> If of_i2c.c needs irq definitions, it should include linux/irq.h
> directly, not assume indirect inclusion via asm/prom.h.

Grant, I assume you're going to merge this one.

Acked-by: Ralf Baechle <>


<Prev in Thread] Current Thread [Next in Thread>