[Top] [All Lists]

Re: [PATCH 6/8] MIPS: Convert DMA to use dma-mapping-common.h

To: David Daney <>,
Subject: Re: [PATCH 6/8] MIPS: Convert DMA to use dma-mapping-common.h
From: Kevin Cernekee <>
Date: Sat, 9 Oct 2010 18:17:28 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=aloB0mYiTQ5ln7L/NdG/WD9HjgYaVDlGPmSHkZo48UU=; b=mTobAH/jH0QhlN+s/qM5WF8iCEi281J7aDaiwjkyIBRwesF+wOh3o3IR478Dq63kpP FQYSldVtZlqv9LU4M3fmYjCUICkVOqA2I1G3AQtauAloDyPWmbMFPFeDTnIEutwheX13 ksth2Fk8v2f/czi5mSTkJyTD4GUc1tKCSWNYs=
Domainkey-signature: a=rsa-sha1; c=nofws;; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=f1I9juQNkPpocgl6RZnJ4FsC/2Z4rNrEZCetNnMbU1Z1GzpjgepcltEleMoPcO3e9+ Z15XvlyROshVFggmguxU+LhHC4Ms19ahqzGK97qPcjJGiyoRSpOYpRiVmjHhq5mLxxq1 R561e7oQpKAI0iui7BZveOTQs0LT5ZQt2OZr0=
In-reply-to: <>
Original-recipient: rfc822;
References: <> <>
On Fri, Oct 1, 2010 at 1:27 PM, David Daney <> wrote:
> diff --git a/arch/mips/include/asm/mach-generic/dma-coherence.h 
> b/arch/mips/include/asm/mach-generic/dma-coherence.h
> index 8da9807..8259966 100644
> --- a/arch/mips/include/asm/mach-generic/dma-coherence.h
> +++ b/arch/mips/include/asm/mach-generic/dma-coherence.h
> @@ -17,12 +17,6 @@ static inline dma_addr_t plat_map_dma_mem(struct device 
> *dev, void *addr,
>        return virt_to_phys(addr);
>  }
> -static inline dma_addr_t plat_map_dma_mem_page(struct device *dev,
> -       struct page *page)
> -{
> -       return page_to_phys(page);
> -}
> -

I was attempting to rebase the HIGHMEM DMA patch against mips-queue,
and ran into a problem with this change:

mips_dma_map_sg() and mips_dma_map_page() now assume that it is
possible to convert any "struct page" to a VA, then convert that VA to
a PA.  This is not necessarily true for HIGHMEM pages (it is perfectly
valid for page_address(page) == NULL).  For cases where we are passed
a "struct page" instead of a VA, it is desirable to be able to call
plat_map_dma_mem_page() directly on the struct page.

Since this function is not implemented as a trivial page_to_phys()
wrapper on all MIPS platforms, I believe it would need to be
reinstated in order to support direct page->PA translation.

<Prev in Thread] Current Thread [Next in Thread>