[Top] [All Lists]

Re: [PATCH v6 4/7] MIPS: add support for hardware performance events (sk

To: Matt Fleming <>
Subject: Re: [PATCH v6 4/7] MIPS: add support for hardware performance events (skeleton)
From: Deng-Cheng Zhu <>
Date: Sat, 25 Sep 2010 10:53:34 +0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=2k50RZZzSm+r2Nmcou6aEyagI7yhT71Bluuz3iVc2gI=; b=Wtr5Pv5Q5v43FzF9+Y9ibui/PTOnrsoDUoSGjFFf72DUtjiIXimtyNHFSvdpIxIn3M iVw1U/VYiqLoYKaq6bw5YUHiD4H5pisezK1hkzFwKLL0DP0WNdlGqpNoEUNaNawhT04+ DkzA9afq3o9Y7upGNkLN0AD7ZSDCVLdhijxm8=
Domainkey-signature: a=rsa-sha1; c=nofws;; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=rSny/jN/eecfJO94r/zctSKiQTme6VzuY/owUC4cM56Y5/lG6KECnsS681ZuLAIYIN wJJyhHufgNcDTG9h5ZR9ZALOXdY3mcDNs2TEptZobBxr4l3INNIhSyx35eYEsxo7nbTI K8jztYRbaIKyWMblK+4VUzs7Hy7E/edxLdY5E=
In-reply-to: <>
References: <> <> <> <> <>
2010/9/24 Matt Fleming <>:
> The potential problem with doing a cleanup patch after this series has
> been merged is that it will modify most of the code in this patch
> series - essentially rewriting it. I don't have a strong opinion
> either way but Ralf may.
[DC]: No, the situation is not that serious. The mips_pmu registration
mechanism had already been implemented. You may take a look at the
bottom of perf_event_mipsxx.c (patch #6). The ugly conditional code
(mips_pmu_irq) could be fixed easily, I suppose.


<Prev in Thread] Current Thread [Next in Thread>