[Top] [All Lists]

Re: [rtc-linux] [PATCH v3] RTC: Add JZ4740 RTC driver

To: Lars-Peter Clausen <>, Andrew Morton <>
Subject: Re: [rtc-linux] [PATCH v3] RTC: Add JZ4740 RTC driver
From: Wan ZongShun <>
Date: Sun, 20 Jun 2010 09:30:28 +0800
Cc:, Ralf Baechle <>,,, Alessandro Zummo <>, Paul Gortmaker <>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=U5tupSyYqe0SUDRD0W1oFKtB1SpC/prq12mUZ3KtVz8=; b=vPMEKr2Osd3ljo2+1Y/3ZarJpEw8QG/C1Hpcv0LZV8+bZT2y/2c5hsJ3LUzFJ+vm5J prXv5rijlrJdTrJ1IWXapQTNBIdT0p+hRWZIW4TAIUHZrsw1+S6k0i+7sa4C/J9B45sk Nknn+frL7VIWemq8Wg8OdG9bWDspdFnwj3zT4=
Domainkey-signature: a=rsa-sha1; c=nofws;; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=xbweHEPQNahqHFVwdxflMMLZSQJkYSrz1sNWUOaybb5SIoFQgllDpoQ/toseQgYxRv Zf+boSkwxxZ/VJanZ23yJK5zB9uuAAT1wAWCf8D+slseMBfdWLg17koFBXOiZYjJERaz lJdHsPpIzlQOKdavwcx8aT3WdOFgKeUR5zVEY=
In-reply-to: <>
References: <> <> <> <>
User-agent: Thunderbird (X11/20100411)
Lars-Peter Clausen :
Wan ZongShun wrote:
This patch adds support for the RTC unit on JZ4740 SoCs.

Signed-off-by: Lars-Peter Clausen <>
Cc: Alessandro Zummo <>
Cc: Paul Gortmaker <>

Changes since v1
- Use dev_get_drvdata directly instead of wrapping it in dev_to_rtc
- Add common implementation for jz4740_rtc_{alarm,update}_irq_enable
- Check whether rtc structure could be allocated
- Remove deadlocks which could occur if the HW was broken

Changes since v2
- Use kzalloc instead of kmalloc
- Propagate errors in jz4740_rtc_reg_write up to its callers
Acked-by: Wan ZongShun <>

Andrew, the v3 patch has fixed some above issues, it looks good to me
Could you please consider merging it to your git tree?


As written in the introduction mail to this thread it would be good if
the majority of the patches could go through Ralfs tree.
So if the patch is good an "Acked-by:" would be preferable.

Okay, Sound like good to me, please do you want to do.
Acked-by: Wan ZongShun <>

- Lars

<Prev in Thread] Current Thread [Next in Thread>