[Top] [All Lists]

Re: [PATCH v5 07/12] MIPS/Perf-events: add raw event support for mipsxx

To: Deng-Cheng Zhu <>
Subject: Re: [PATCH v5 07/12] MIPS/Perf-events: add raw event support for mipsxx 24K/34K/74K/1004K
From: David Daney <>
Date: Thu, 27 May 2010 15:48:46 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=Yjjw14SqQEQ718/RaSBpmqSVV3PH1fbnvEETkMt14jQ=; b=QVagKXG+SqO/4iAMspDGTkSl1c7FzLzdGMng1kk7jnM4XN0KyzzJqUQQdL5BFiXlcx jE2ZARShwCXieoJtUjClkNoOaFVNcJCFdnXOg8yoi5U7P/2OJvGiJyUC71qOvpmAiZB5 TrYEr2mnFGtZ7lb25gn0BhkNtxkWS4svx03s0=
Domainkey-signature: a=rsa-sha1; c=nofws;; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=MxRuFHwdwgirQORY/OwnNAar60NwCzoB/u4P9KPyGNaraur9XNkPCPsAXO90RBe222 p8ovHwzAApEY8DTT8Zw38SryRtChIYZHE++WRds73jez298iRSSAF3wEiELT462tH/p+ uBhfvlHajZPZdcWKPjdyolLcMo65jXjP+AiVs=
In-reply-to: <>
Original-recipient: rfc822;
References: <> <>
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100330 Fedora/3.0.4-1.fc12 Thunderbird/3.0.4
On 05/27/2010 06:03 AM, Deng-Cheng Zhu wrote:
Raw event is an important part of Perf-events. It helps the user collect
performance data for events that are not listed as the generic hardware
events and cache events but ARE supported by the CPU's PMU.

This patch adds this feature for mipsxx 24K/34K/74K/1004K. For how to use
it, please refer to processor core software user's manual and the
comments for mipsxx_pmu_map_raw_event() for more details.

Please note that this is a "precise" implementation, which means the
kernel will check whether the requested raw events are supported by this
CPU and which hardware counters can be assigned for them.

Signed-off-by: Deng-Cheng Zhu<>
  arch/mips/kernel/perf_event.c        |    4 +
  arch/mips/kernel/perf_event_mipsxx.c |  152 +++++++++++++++++++++++++++++++++-
  2 files changed, 155 insertions(+), 1 deletions(-)

Should this just be folded into the other patches?

I would also reiterate that perhaps the generic support functions be separated from the processor specific event definitions.

David Daney

<Prev in Thread] Current Thread [Next in Thread>