[Top] [All Lists]

Re: [PATCH] Make MIPS dynamic clocksource/clockevent clock code generic

To: Thomas Gleixner <>
Subject: Re: [PATCH] Make MIPS dynamic clocksource/clockevent clock code generic
From: Linus Walleij <>
Date: Tue, 20 Oct 2009 23:27:55 +0200
Cc: Linus Walleij <>,,,, Mikael Pettersson <>, Ralf Baechle <>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=yAyQJ4Q1QRqp67DoPTaU4e8Wkxqxk8+mKYCmNxjf2Po=; b=PDAhNPTA6PobneKJrfFPZ4MuKgwO7s8dQ56WME+oDO3NwVmGM1fWVDCUKLN2KlF4ZM 3PQ2xa7ydEEnxq9d18BqFolTYAqeqLBHpP4pMWMZxy5hXGiT0KN2QdCRJAK3mPv/uoJh 3QNtMdghe35MZ/9n+MTXMfuLIF1U4T7AHJdkg=
Domainkey-signature: a=rsa-sha1; c=nofws;; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=DX0PiqghZrxHucjX46fJJ6bGZl26H0pbfSASllJq3plSywOmHs9Blc69PeT63RlmXV GrpJJMxw04K1EOagRV1VnC4d/0Mwz7nVXuUsAYDKgEJ4CflJIJFoRy57eFcFXLlSUb7V ejEgrxrrnmd971eV7rBissfmd8xLAVJFXHgig=
In-reply-to: <alpine.LFD.2.00.0910200454300.2863@localhost.localdomain>
Original-recipient: rfc822;
References: <> <alpine.LFD.2.00.0910200454300.2863@localhost.localdomain>
2009/10/20 Thomas Gleixner <>:

> On Sun, 18 Oct 2009, Linus Walleij wrote:
>> This moves the clocksource_set_clock() and clockevent_set_clock()
>> from the MIPS timer code into clockchips and clocksource where
>> it belongs.
> (...)
> Please do not make that functions inline. They are too large and there
> is no benefit of inlining them.

I think there is, because these functions in MIPS if I'm not misreading it, are
used once each in one and one spot only in the clocksource/clockevent
set-up at boot time for each platform in which they are currently used.

Further these spots tend to be __init or even __cpuinit code segments,
so they will be discarded and if we inline the code it will be discarded
after boot as well.

If you foresee that the code will be used in other ways under other
circumstances, I will make them non-inlined of course, but I have a
hard time seeing that.


Linus Walleij

<Prev in Thread] Current Thread [Next in Thread>