[Top] [All Lists]

[PATCH 1/2] tracing: convert trace_clock_local() as weak function

To:, linux-mips <>
Subject: [PATCH 1/2] tracing: convert trace_clock_local() as weak function
From: Wu Zhangjin <>
Date: Fri, 16 Oct 2009 19:38:24 +0800
Cc: Ralf Baechle <>, Thomas Gleixner <>, Steven Rostedt <>, Ingo Molnar <>, Manuel Lauss <>, Atsushi Nemoto <>, Wu Zhangjin <>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer; bh=IlDKtp0qWL6jn+JcvdkEIHu8PFwWmThMcXB/9t1cWX0=; b=m2BNobI48l7X/vE3HvXZ7SNTcTtfoRvBKEIU7Tk/nmXXRGcWiKICBtBWHEEo9rx61Y fX/xAtcrr5sSIlJsnftM/BbxfC8RJmEx43NF4CNTMUnkqLJiAXejgPfRrp0HliEnFbFH h4vxRzimgNtrIv4+hrTqDBI1L62IEwj3aKHaM=
Domainkey-signature: a=rsa-sha1; c=nofws;; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=BDT8mK4bOnvB+QbLgtuEnq8/qgU/J2zhRdblv7+6nPfefN9hRH4KImeOp/ucA26lFk iC96s/2xNAbatELeUQIN3r/Yjp12+lQb3C+mGRv7BhZK9+DzIlfPpVdmwM+8yn6rsrvZ uBQQ9Yt8NUSYsjgkshcuEYzl8i/DsmTV96s3I=
Original-recipient: rfc822;
trace_clock_local() is based on the arch-specific sched_clock(), in X86,
it is tsc(64bit) based, which can give very high precision(about 1ns
with 1GHz). but in MIPS, the sched_clock() is jiffies based, which can
give only 10ms precison with 1000 HZ. which is not enough for tracing,
especially for Real Time system.

so, we need to implement a MIPS specific sched_clock() to get higher
precision. There is a tsc like clock counter register in MIPS, whose
frequency is half of the processor, so, if the cpu frequency is 800MHz,
the time precision reaches 2.5ns, which is very good for tracing, even
for Real Time system.

but 'Cause it is only 32bit long, which will rollover quickly, so, such
a sched_clock() will bring with extra load, which is not good for the
whole system. so, we only need to implement a arch-specific
trace_clock_local() for tracing. as a preparation, we convert it as a
weak function.

The MIPS specific trace_clock_local() is coming in the next patch.

Signed-off-by: Wu Zhangjin <>
 kernel/trace/trace_clock.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/trace/trace_clock.c b/kernel/trace/trace_clock.c
index 20c5f92..a04dc18 100644
--- a/kernel/trace/trace_clock.c
+++ b/kernel/trace/trace_clock.c
@@ -26,7 +26,7 @@
  * Useful for tracing that does not cross to other CPUs nor
  * does it go through idle events.
-u64 notrace trace_clock_local(void)
+u64 __attribute__((weak)) notrace trace_clock_local(void)
        unsigned long flags;
        u64 clock;

<Prev in Thread] Current Thread [Next in Thread>