|From:||David Daney <firstname.lastname@example.org>|
|Date:||Fri, 14 Aug 2009 11:24:19 -0700|
|Cc:||Adam Nemet <email@example.com>|
|User-agent:||Thunderbird 126.96.36.199 (X11/20090320)|
In atomic.h for atomic_add we have this gem: __asm__ __volatile__( " .set mips3 \n" "1: ll %0, %1 # atomic_add \n" " addu %0, %2 \n" " sc %0, %1 \n" " beqz %0, 2f \n" " .subsection 2 \n" "2: b 1b \n" " .previous \n" " .set mips0 \n" What is the purpose of the .subsection here?It will not affect branch prediction in the beqz as nothing happens in .subsection 2.
For spin locks it is clear that this technique can help, but for atomic_add I don't think so. To make matters worse for some code the subsection is going out of branch range.
|<Prev in Thread]||Current Thread||[Next in Thread>|
|Previous by Date:||Re: MIPS: Avoid clobbering struct pt_regs in kthreads, David Daney|
|Next by Date:||Re: .subsection madness, Ralf Baechle|
|Previous by Thread:||Re: MIPS: Avoid clobbering struct pt_regs in kthreads, David Daney|
|Next by Thread:||Re: .subsection madness, Ralf Baechle|
|Indexes:||[Date] [Thread] [Top] [All Lists]|