[Top] [All Lists]

Re: [PATCH 10/10] bcm63xx: clarify meaning of the magical value in ehci-

To: Maxime Bizon <>
Subject: Re: [PATCH 10/10] bcm63xx: clarify meaning of the magical value in ehci-bcm63xx.c
From: Sergei Shtylyov <>
Date: Mon, 01 Jun 2009 21:57:56 +0400
Cc:, Ralf Baechle <>, Florian Fainelli <>
In-reply-to: <>
Organization: MontaVista Software Inc.
Original-recipient: rfc822;
References: <> <>
User-agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803

Maxime Bizon wrote:

USB maintainer asked for clarification of the magic value used during
USB init. Be clear about the source of it.

Signed-off-by: Maxime Bizon <>
 drivers/usb/host/ehci-bcm63xx.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/host/ehci-bcm63xx.c b/drivers/usb/host/ehci-bcm63xx.c
index 8a62c0a..5a03fdd 100644
--- a/drivers/usb/host/ehci-bcm63xx.c
+++ b/drivers/usb/host/ehci-bcm63xx.c
@@ -78,7 +78,9 @@ static int __devinit ehci_hcd_bcm63xx_drv_probe(struct 
platform_device *pdev)
        bcm_rset_writel(RSET_USBH_PRIV, reg, USBH_PRIV_SWAP_REG);
- /* don't ask... */
+       /* the magic value comes for the original vendor BSP and is
+        * needed for USB to work. Datasheet does not help, so the
+        * magic value is used as-is. */
        bcm_rset_writel(RSET_USBH_PRIV, 0x1c0020, USBH_PRIV_TEST_REG);
hcd = usb_create_hcd(&ehci_bcm63xx_hc_driver, &pdev->dev, "bcm63xx");

   Documentation/CodingStyle, chapter 8:

The preferred style for long (multi-line) comments is:

         * This is the preferred style for multi-line
         * comments in the Linux kernel source code.
         * Please use it consistently.
         * Description:  A column of asterisks on the left side,
         * with beginning and ending almost-blank lines.

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>