[Top] [All Lists]

Re: [loongson-PATCH-v1 03/27] fix-error: incompatiable argument type of

Subject: Re: [loongson-PATCH-v1 03/27] fix-error: incompatiable argument type of clear_user
From: Ralf Baechle <>
Date: Thu, 21 May 2009 08:51:04 +0100
Cc:, Yan hua <>, Philippe Vachon <>, Zhang Le <>, Zhang Fuxin <>, Arnaud Patard <>,,, Nicholas Mc Guire <>, Liu Junliang <>, Erwan Lerale <>
In-reply-to: <>
Original-recipient: rfc822;
References: <> <>
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, May 21, 2009 at 05:50:01AM +0800, wrote:

> From: Wu Zhangjin <>
> there are lots of warnings about the macro: clear_user in linux-mips.
> the type of the second argument of access_ok should be (void __user *),
> but there is an un-needed (unsigned long) conversion before __cl_addr,
> so, remove the (unsigned long) will fix this problem.

I assume you're talking about sparse warnings, not gcc warnings?

Either way, access_ok() is defined to take pointer arguments, so patch
applied.  Thanks!


<Prev in Thread] Current Thread [Next in Thread>