On Thu, Jan 15, 2009 at 11:38:18AM -0800, David Daney wrote:
>> Add the name set by set_irq_chip_and_handler_name() to the output of
> Alchemy is the only mips cpu that uses set_irq_chip_and_handler_name()...
> ... so for most mips CPUs we now get something ugly like this:
> octeon:~# cat /proc/interrupts
> CPU0 CPU1 CPU2 CPU3
> 23: 7371 7120 5747 5373 Core-<NULL>
Ouch, I see. Well, I certainly have no objections if you want to revert
the patch, but I like that I can see how triggers are set up (nice esp.
for gpio's and my homebrew userspace gpio interface).
Or how about this?
From: Manuel Lauss <firstname.lastname@example.org>
Subject: [PATCH] MIPS: only print handler name if its actually set.
David Daney reports that Alchemy is the only in-tree user of
set_irq_handler_and_name(). On other systems this leaves ugly
"-<NULL>" strings in cpuinfo.
So, only print the handler string if it was actually set.
Signed-off-by: Manuel Lauss <email@example.com>
arch/mips/kernel/irq.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/mips/kernel/irq.c b/arch/mips/kernel/irq.c
index a0ff2b6..9061ae9 100644
@@ -111,7 +111,8 @@ int show_interrupts(struct seq_file *p, void *v)
seq_printf(p, "%10u ", kstat_cpu(j).irqs[i]);
seq_printf(p, " %14s", irq_desc[i].chip->name);
- seq_printf(p, "-%-8s", irq_desc[i].name);
+ if (irq_desc[i].name)
+ seq_printf(p, "-%-8s", irq_desc[i].name);
seq_printf(p, " %s", action->name);
for (action=action->next; action; action = action->next)