[Top] [All Lists]

Re: [PATCH] cpumask fallout: Initialize irq_default_affinity earlier.

To: David Daney <>
Subject: Re: [PATCH] cpumask fallout: Initialize irq_default_affinity earlier.
From: Mike Travis <>
Date: Thu, 08 Jan 2009 13:25:47 -0800
Cc: Linus Torvalds <>,,,
In-reply-to: <>
Original-recipient: rfc822;
References: <> <alpine.LFD.2.00.0901081227360.3283@localhost.localdomain> <>
User-agent: Thunderbird (X11/20070801)
David Daney wrote:
> Linus Torvalds wrote:
> [...]
>> In fact, I think it already is a no-op in the UP case, and you can
>> literally just do
>>     static inline void __init init_irq_default_affinity(void)
>>     {
>>          alloc_cpumask_var(&irq_default_affinity, GFP_KERNEL);
>>          cpumask_setall(irq_default_affinity);
>>     }
>> and be done with it. I think it should all compile away to nothing if
>> CONFIG_SMP isn't set.
> The 'inline' seems gratuitous to me.  Since it is static GCC should do
> the Right Thing.  However since you suggested it, I am testing it that way.
> David Daney

It will probably need to be:


I am testing it on x86_64 as well.


<Prev in Thread] Current Thread [Next in Thread>