[Top] [All Lists]

Re: [PATCH 2/3] Alchemy: Move evalboard code to common directory

To: Kevin Hickey <>
Subject: Re: [PATCH 2/3] Alchemy: Move evalboard code to common directory
From: Sergei Shtylyov <>
Date: Wed, 12 Nov 2008 13:35:22 +0300
Cc: Manuel Lauss <>, Linux-MIPS <>, Florian Fainelli <>, Bruno Randolf <>
In-reply-to: <>
Original-recipient: rfc822;
References: <> <> <> <>
User-agent: Thunderbird (Windows/20080914)

Kevin Hickey wrote:

And in keeping with my other email, I think that the evalboards
directory is a good idea (though I would recommend the name
"develboards" as that is what DB stands for), but it should contain

  I'd prefer devel-boards, or dev-boards.

subdirectories for each board and a common directory for common DB code.
Smashing all of the board code into one file doesn't leave any room to
grow if that file gets too big.

I doubt that this could be the case here. And I don't think anybody has placed limits on the source file size so far.

Also, a single common.c will not be sufficient in the future.

Wait, the file only includes prom_init() for now, so might be worth renaming it...


On Sat, 2008-11-08 at 13:08 +0100, Manuel Lauss wrote:
Move all code of the Pb/Db boards to a single subdirectory and extract
some common code.

Signed-off-by: Manuel Lauss <>

   And now I'll have to give Kevin two lessons of the network etiquette:

- don't top-post (your comments should be below the quoted text you're replying to); - above all, don't leave tens of KBs of uncommented patch behind, do spend several seconds to delete it!

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>