[Top] [All Lists]

Re: [PATCH 15/36] Probe for Cavium OCTEON CPUs.

To: Ralf Baechle <>
Subject: Re: [PATCH 15/36] Probe for Cavium OCTEON CPUs.
From: David Daney <>
Date: Wed, 29 Oct 2008 09:18:07 -0700
Cc:, Tomaso Paoletti <>, Paul Gortmaker <>
In-reply-to: <>
Original-recipient: rfc822;
References: <> <> <> <> <> <> <> <> <> <> <>
User-agent: Thunderbird (X11/20080723)
Ralf Baechle wrote:

We probably should move the mips_probe_watch_registers() into
mips_probe_watch_registers().  I notice the function is only getting
called from cpu_probe_mips().  Iow the watch register support won't work
for CPUs made by any other vendor.  So I suggest below patch.  Plus
all of the above patch sans the mips_probe_watch_registers call on top.


Signed-off-by: Ralf Baechle <>

diff --git a/arch/mips/kernel/cpu-probe.c b/arch/mips/kernel/cpu-probe.c
index 0cf1545..008230f 100644
--- a/arch/mips/kernel/cpu-probe.c
+++ b/arch/mips/kernel/cpu-probe.c

Acked-by: David Daney <>

This seems sane to me assuming that alchemy, sibyte, sandcraft, nxp, and broadcom all have standard mips{32,64} watch registers (i.e., if the watch bit in config1 is set the registers have mips semantics).

David Daney

<Prev in Thread] Current Thread [Next in Thread>