[Top] [All Lists]

Re: [PATCH] defined a macro for lemote 2e box IO base

To: "Maciej W. Rozycki" <>
Subject: Re: [PATCH] defined a macro for lemote 2e box IO base
From: Zhang Le <>
Date: Sat, 25 Oct 2008 15:31:54 +0800
Cc: Ralf Baechle <>,
In-reply-to: <>
Mail-followup-to: "Maciej W. Rozycki" <>, Ralf Baechle <>,
Original-recipient: rfc822;
References: <> <> <> <>
User-agent: Mutt/1.5.16 (2007-06-09)
On 21:24 Fri 24 Oct     , Maciej W. Rozycki wrote:
> On Fri, 24 Oct 2008, Zhang Le wrote:
> > Thanks for the comment.
> > I have checked how other platforms handle this problem.
> > Many have used CKSEG1ADDR.
>  Please note long-term we want CKSEG1ADDR() to go away from board/platform 
> code and possibly only keep it for some generic use if at all.  Have you 
> considered using ioremap()?  With a literal physical address it should get 
> optimised to the same code as the use of CKSEG1ADDR() produces, yet keep 
> the source portable and in line with the rest of the kernel.

Thank you!
I will make a new patch.

Zhang, Le

<Prev in Thread] Current Thread [Next in Thread>