[Top] [All Lists]

Re: [PATCH 2/2] TXx9: Add TX4939 ATA support (v2)

To: Atsushi Nemoto <>
Subject: Re: [PATCH 2/2] TXx9: Add TX4939 ATA support (v2)
From: Alan Cox <>
Date: Mon, 22 Sep 2008 19:47:22 +0100
In-reply-to: <>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903
Original-recipient: rfc822;
References: <> <> <> <>
On Tue, 23 Sep 2008 00:16:02 +0900 (JST)
Atsushi Nemoto <> wrote:

> On Mon, 22 Sep 2008 19:01:57 +0400, Sergei Shtylyov <> 
> wrote:
> > >>  BTW, how about supporting IDE aboard RBTX4938, not worth the trouble?
> > 
> > > Yes, next plan.  It should be much simpler than the tx4939ide driver.
> > 
> >     I suspect {ide|pata}_platform could be able to cover it... though I got 
> > muddled in the timing diagrams for the TX4938 external bus...
> We need .set_pio_mode routine to get best PIO speed, but current
> {ide|pata}_platform driver does not provide a hook for it (please
> correct me if I was wrong).  So current code I have does not use
> ide_platform...

You are correct. The platform driver is intended to be totally dumb. It's
not clear at what point having a specific driver is more sensible as a
libata driver is tiny anyway (especially with tejuns inherited ops stuff)

<Prev in Thread] Current Thread [Next in Thread>