[Top] [All Lists]

Re: [PATCH 1/2] ide: Add tx4939ide driver (v2)

To: Atsushi Nemoto <>
Subject: Re: [PATCH 1/2] ide: Add tx4939ide driver (v2)
From: Bartlomiej Zolnierkiewicz <>
Date: Thu, 18 Sep 2008 16:45:09 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:message-id; bh=HY+ytoVFskxwiuZtTLJRpU1mxO9c2ndCEbfp1OHLk9A=; b=rEKvVIuwF9YE1G/VneHFi15+JY1Vo5jQmNcqXfKhqQNnlbQ/j7QHD77ckukUn4Ieqw 535SG2TOYn865qAlcy0ZzPpXPA/JP0YyzdKG5/1uofyA+q+HNSybJTJqLm56JpuHyMWl qstnYW+kYVrOu9UkeN6aTbAyMaaiCQDsh0RSk=
Domainkey-signature: a=rsa-sha1; c=nofws;; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:message-id; b=P/0PlEWChxluSmBONOkDs9U8/GWGKvZpML5R1m3ITS50d/ET6SMz8xaknfJPYLO7dl ksQUuq0Bk/qG5j17F6bKAbNCmDR70tiriIEWc0w5L2JKzsI5RksB3N5EAcLE6xm7lzDl DIKYbPX+1/uSj+3RDO5rdnYJ+KVvzUG8Lb5yI=
In-reply-to: <>
Original-recipient: rfc822;
References: <>
User-agent: KMail/1.9.9
On Wednesday 17 September 2008 08:13:42 Atsushi Nemoto wrote:
> This is the driver for the Toshiba TX4939 SoC ATA controller.
> This controller has standard ATA taskfile registers and DMA
> command/status registers, but the register layout is swapped on big
> endian.  There are some other endian issue and some special registers
> which requires many custom dma_ops/port_ops routines.
> Signed-off-by: Atsushi Nemoto <>
> ---
> This patch is against linux-next 20080916.
> Changes since v1:
> * rework IO accessors
> * rework pio/dma timing setup
> * use ide_get_pair_dev
> * do not do ATA hard reset
> * and so on  (Many thanks to Sergei)

Sergei, are you OK with this version?

[ I tentatively applied it to pata tree.  I still see the use of legacy
  HWIF()/HWGROUP() macros but I can deal with it myself before pushing
  the patch upstream. ]

<Prev in Thread] Current Thread [Next in Thread>