[Top] [All Lists]

Re: [PATCH] IP28: fix MC GIOPAR setting

To: peter fuerst <>
Subject: Re: [PATCH] IP28: fix MC GIOPAR setting
From: (Thomas Bogendoerfer)
Date: Fri, 21 Mar 2008 22:32:33 +0100
In-reply-to: <Pine.LNX.4.58.0803212125050.523@Indigo2.Peter>
Original-recipient: rfc822;
References: <Pine.LNX.4.58.0803211535570.423@Indigo2.Peter> <> <Pine.LNX.4.58.0803212125050.523@Indigo2.Peter>
User-agent: Mutt/1.5.13 (2006-08-11)
On Fri, Mar 21, 2008 at 10:07:38PM +0100, peter fuerst wrote:
> > is there a reason to restrict this to IP28 only ?
> Would indeed be most surprising, if this isn't appropriate for any Indigo2-
> Impact, but don't know for sure.  And can't check, whether it at least doesn't
> hurt Non-Impact Indigo2.  Of course, being able to avoid '#ifdef' at all would
> be the prettiest alternative.

I'll check my IP22 machines, if they are ok with that change. Another
solution could be to have gio_set_master() similair to pci_set_master().
That way we only enable master, if it is requested by a driver.


Crap can work. Given enough thrust pigs will fly, but it's not necessary a
good idea.                                                [ RFC1925, 2.3 ]

<Prev in Thread] Current Thread [Next in Thread>