[Top] [All Lists]

Re: [PATCH][MIPS][5/6]: AR7: serial hack

To: (Thomas Bogendoerfer)
Subject: Re: [PATCH][MIPS][5/6]: AR7: serial hack
From: Alan Cox <>
Date: Tue, 18 Mar 2008 14:01:33 +0000
Cc: Matteo Croce <>,, Florian Fainelli <>, Felix Fietkau <>, Nicolas Thill <>,, Andrew Morton <>
In-reply-to: <>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903
Original-recipient: rfc822;
References: <> <> <> <> <>
> Is there a good reason, why we don't check for BOTH_EMPTY in
> serial8250_console_putchar() ? To match the 2.6.10 behaviour we

A very good one - we have at least 1 byte of FIFO and the serial-ethernet
magic console devices also use that fifo emptying entirely to deduce when
to send a new packet.

> would need that and this would fix the AR7 case without any
> special handling.

If the AR7 is an 8250 why does it need special handling? and indeed why
does serial work on it except for console - or does that fail too.

<Prev in Thread] Current Thread [Next in Thread>