[Top] [All Lists]

Re: (Try #3) [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles

To: WANG Cong <>
Subject: Re: (Try #3) [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles
From: Ralf Baechle <>
Date: Fri, 11 Jan 2008 14:17:54 +0000
Cc: Sam Ravnborg <>, Andreas Schwab <>, LKML <>,, Andrew Morton <>,
In-reply-to: <20080102062135.GE2493@hacking>
Original-recipient: rfc822;
References: <20080101071311.GA2496@hacking> <20080101072238.GC2496@hacking> <> <> <> <20080102062135.GE2493@hacking>
User-agent: Mutt/1.5.17 (2007-11-01)
On Wed, Jan 02, 2008 at 02:21:36PM +0800, WANG Cong wrote:

> >> Shouldn't that use $(LINUXINCLUDE), or $(KBUILD_CPPFLAGS)?
> >It would be better to use $(LINUXINCLUDE) as we then pull in all config
> >symbols too and do not have to hardcode kbuild internal names (include2).
> OK. Refine this patch.

LDSCRIPT also needed fixing to get builds in a separate object directory
working again.

I've applied below fix.


<Prev in Thread] Current Thread [Next in Thread>