[Top] [All Lists]

Re: [PATCH] enable PCI bridges in MIPS ip32

To: Giuseppe Sacco <>
Subject: Re: [PATCH] enable PCI bridges in MIPS ip32
From: Ralf Baechle <>
Date: Thu, 4 Oct 2007 16:19:51 +0100
Cc: "Maciej W. Rozycki" <>,
In-reply-to: <1191508413.10050.26.camel@scarafaggio>
Original-recipient: rfc822;
References: <> <> <> <1191508413.10050.26.camel@scarafaggio>
User-agent: Mutt/1.5.14 (2007-02-12)
On Thu, Oct 04, 2007 at 04:33:33PM +0200, Giuseppe Sacco wrote:

> Il giorno gio, 04/10/2007 alle 14.03 +0100, Ralf Baechle ha scritto:
> [...]
> > (of course this all goes far beyond Giuseppe's patch - but the whole
> > ops-mace.c file like so much of the other code in arch/mips/pci isn't
> > exactly an example to be copied.
> > 
> > Ah, one final formality - when sending a patch please add a
> > Signed-off-by: line.  See Documentation/SubmittingPatches in the kernel
> > tree for what this means.
> I'll provide a new patch tomorrow, using inline functions instead of
> macros. About the maximum number of PCI buses, I used 1 since the ip32
> only have 1 slot. If this maximum value should be changed, please let me
> know.

The entire testing done by chkslot() is probably not needed, so I suggest
you try to simply dump the thing entirely and test.


<Prev in Thread] Current Thread [Next in Thread>