[Top] [All Lists]

Re: [PATCH][MIPS][7/7] AR7: ethernet

To: Thiemo Seufer <>
Subject: Re: [PATCH][MIPS][7/7] AR7: ethernet
From: Ralf Baechle <>
Date: Thu, 13 Sep 2007 12:35:47 +0100
Cc: Matteo Croce <>,, Eugene Konev <>,,,,,,,,, Andrew Morton <>, Jeff Garzik <>
In-reply-to: <>
Original-recipient: rfc822;
References: <> <> <> <>
User-agent: Mutt/1.5.14 (2007-02-12)
On Thu, Sep 13, 2007 at 02:42:46AM +0100, Thiemo Seufer wrote:

> > All struct members here are sized such that there is no padding needed, so
> > the packed attribute doesn't buy you anything - unless of course the
> > entire structure is missaligned but I don't see how that would be possible
> > in this driver so the __attribute__ ((packed)) should go - it result in
> > somwhat larger and slower code.
> FWIW, a modern gcc will warn about such superfluous packed attributes,
> that's another reason to remove those.

I doubt it will in this case; the packed structure is dereferenced by a
pointer so no way for gcc to know the alignment.


<Prev in Thread] Current Thread [Next in Thread>