On 13/07/07 11:12 +0200, Domen Puncer wrote:
> On 11/07/07 21:34 +0100, Russell King wrote:
> > On Wed, Jul 11, 2007 at 10:02:54AM -0700, David Brownell wrote:
> > > On Wednesday 11 July 2007, Christoph Hellwig wrote:
> > > > On Wed, Jul 11, 2007 at 08:56:58AM -0700, David Brownell wrote:
> > > > > > Umm, this is about the fifth almost identical implementation of
> > > > > > the clk_ functions. Please, please put it into common code.
> > > > > >
> > > > > > And talk to the mips folks which just got a similar comment from me.
> > > > >
> > > > > You mean like a lib/clock.c core, rather than an opsvector?
> > > >
> > > > I mean an ops vector and surrounding wrappers. Every architecture
> > > > is reimplementing their own dispatch table which is rather annoying.
> > >
> > > ARM doesn't. :)
> > >
> > > But then, nobody expects one kernel to support more than one
> > > vendor's ARM chips; or usually, more than one generation of
> > > that vendor's chips. So any dispatch table is specific to
> > > a given platform, and tuned to its quirks. Not much to share
> > > between OMAP and AT91, for example, except in some cases maybe
> > > an arm926ejs block.
> > And also the information stored within a 'struct clk' is very platform
> > dependent. In the most basic situation, 'struct clk' may not actually
> > be a structure, but the clock rate. All functions with the exception of
> > clk_get() and clk_get_rate() could well be no-ops, clk_get() just returns
> > the 'struct clk' representing the rate and 'clk_get_rate' returns that
> > as an integer.
> > More complex setups might want 'struct clk' to contain the address of a
> > clock enable register, the bit position to enable that clock source, the
> > clock rate, a refcount, and so on, all of which would be utterly useless
> > for a platform which had fixed rate clocks.
> The patch that triggered this discussion is at the end.
> It doesn't make any assumption on struct clk, it's just a
> wrapper around functions from clk.h.
> Point of this patch was to abstract exported functions, since
> arch/powerpc/ can support multiple platfroms in one binary.
So... the thread just ended without any consensus, ACK or whatever.
Choices I see:
- have EXPORT_SYMBOL for clk.h functions in ie. lib/clock.c and have
every implemenation fill some global struct.
- leave this patch as it is, abstraction only for arch/powerpc/.
- or I can just forget about this, and leave it for the next sucker
who will want nicer clock handling in some driver.