[Top] [All Lists]

Re: [PATCH] Add support for profiling Loongson 2E

To: "John Levon" <>
Subject: Re: [PATCH] Add support for profiling Loongson 2E
From: "Dajie Tan" <>
Date: Thu, 26 Jul 2007 05:14:14 +0400
Cc: "Ralf Baechle" <>, linux-mips <>,,
Dkim-signature: a=rsa-sha1; c=relaxed/relaxed;; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Gdb8ccS3vv9MLm9VtSgMBjw5LCm3wbylYzel2EE8gEwSVEGJJECGPQ1Ftz2wOg8EltmQY9GHwt1MJfLXPYATXJTYS5/vZzHRRyYYDZiE72OQ3+R4cMY5TdgLyYXIEuluPsECW3tCQb/+c2rVE6ZGUBVbNS0uvVwIBs7zwhFXJwg=
Domainkey-signature: a=rsa-sha1; c=nofws;; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=R+HwjWLgcG2QVbZ5AQgrZ6rimpMD7cY7QHEXHQ64PZbYIuN95eIs9wxUnNV52fmWacA6NR4A2mxB7dbt0pXgsiDmtiAvn7fnJF17bWIk+Oqr2oARuEO3iEB/AgVyqmIryjlxo90RwCt5byotUg9P8X2c4QfQ8ls3tjO1xuns5Nw=
In-reply-to: <>
Original-recipient: rfc822;
References: <> <> <> <>
2007/7/25, John Levon <>:
On Wed, Jul 25, 2007 at 07:41:21AM +0400, Dajie Tan wrote:

> >Why do you need this change?  It almost looks as if you're papering over
> >a bug where add_sample should not be called at all.
> Yeah,this change is to enhance the robust of oprofile. When using
> performace counter manually(writting control register in a module, no
> need to use the oprofile),I usually make kernel panic if I do not
> initialize the oprofile and enable the overflow interrupt carelessly.
> So, this change can avoid this panic. :D

This panic is good and should stay. It shows that you've made a mistake.


This panic is caused by accessing a null pointer.Do you think that
accessing a null
pointer is allowed in a robust system ?

<Prev in Thread] Current Thread [Next in Thread>