|Subject:||Generating patches and using checkpatch.pl|
|From:||Daniel Laird <firstname.lastname@example.org>|
|Date:||Thu, 28 Jun 2007 15:37:06 +0100|
|User-agent:||Thunderbird 126.96.36.199 (Windows/20070604)|
I am trying to start feeding back various patches to do with supporting
the hardware I work on.
The company also decided upon a name change so I thought I would do this
So I moved arch/mips/philips to arch/mips/nxp. I generated a patch I ran checkpatch.pl as Ralf suggested before. I now have pages of errors in the patch - Line over 80 chars - printk must have KERN_ debug level - must have a space after this (, or *) - use tabs not spaces - Do not use C99 comments. To name but a few My question is:If you do a patch and find all these errors is it expected that I fix all these problems, or I just make sure my changes do not make it worse!
|<Prev in Thread]||Current Thread||[Next in Thread>|
|Previous by Date:||Re: [PATCH 3/4] rbtx4938: Fix secondary PCIC and glue internal NICs, Atsushi Nemoto|
|Next by Date:||Re: [PATCH 3/4] rbtx4938: Fix secondary PCIC and glue internal NICs, Jeff Garzik|
|Previous by Thread:||[PATCH] TXx9 SPI controller driver (take 2), Atsushi Nemoto|
|Next by Thread:||Re: Generating patches and using checkpatch.pl, Jan-Benedict Glaw|
|Indexes:||[Date] [Thread] [Top] [All Lists]|