[Top] [All Lists]

Re: [PATCH 11/12] drivers: PMC MSP71xx USB driver

Subject: Re: [PATCH 11/12] drivers: PMC MSP71xx USB driver
From: David Brownell <>
Date: Tue, 05 Jun 2007 18:32:43 -0700
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=s1024;; h=Received:X-YMail-OSG:Received:Date:From:To:Subject:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id; b=4KIj5DJaGkJ5QyB8ow8LY7hxaJUMCPSHb0JqCxdv9wbYTznEWhxsTXlSZRWSbB4yZ85T0A1jMQIf8dbmVZHKA4OGnTMTnbwGPlG3OCn5i6t0ZcRXqXj0B8TtshuZE5Yoy5JzM2v6/XVcDAhdk9EbefN6dRx0PoYWeqNmC5D3E2o= ;
In-reply-to: <>
Original-recipient: rfc822;
References: <>
[ $SUBJECT is getting less accurate... ]

There are already big-endian support patches for EHCI in the USB queue.

I strongly suspect this patch will clash with those.  For example,
they obviously don't cope with mixed configuration systems, where
an SOC includes big-endian EHCI registers but there's also PCI which
is "normal"-endian.  The register accessors all accept a handle to
the host controller, so they can figure out which byte sex to use
on an access-by-access basis if the system needs that...

Another split you need to do:  the usb/core/hub.c stuff should
be a patch in its own right.  But hmm, wait ... that looks like
it mirrors something done in another EHCI patch that's already
in the USB queue.  There's some other EHCI silicon that chose the
"software (vs hardware) powers ports off" implementation option.

So you should grab those patches from Greg's queue and redo yours
to match.  Looks like a bunch of the host side work you did has
already been done...

- Dave

<Prev in Thread] Current Thread [Next in Thread>