[Top] [All Lists]

Re: [linux-usb-devel] [PATCH 11/12] drivers: PMC MSP71xx USB driver

Subject: Re: [linux-usb-devel] [PATCH 11/12] drivers: PMC MSP71xx USB driver
From: David Brownell <>
Date: Tue, 05 Jun 2007 15:28:53 -0700
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=s1024;; h=Received:X-YMail-OSG:Received:Date:From:To:Subject:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id; b=UOCXJCTFAVBpcAnmYnvJnzuFfOkeCIEDyxlZrnifeqGNh+V1uxs26qqc5owx25cNQ4Ss3cU8jwWLu1T1vqGkQCpTjHMXYdaD1uCLyTobr0PmJ6FWDE2j2aqcvuZ1l+pjbzpwA7VuppWvoYx4XxD0ugvMMBJ9TR+WacaYfr1RMk4= ;
In-reply-to: <>
Original-recipient: rfc822;
References: <>
> This does far too much to be a single patch.  It needs to be broken up.

Agreed.  300+ KB is not digestible at all.

Most maintainers like to see patches on the order of 10 KB; that much
is easy to review.  New drivers are rarely that small of course, but
that should give you some understanding of just how excessive this is...

But the fact that this one "driver" patch touched so many other files
outside its own directory is a dead giveaway that it's got something
pretty wrong...

- Dave

<Prev in Thread] Current Thread [Next in Thread>