[Top] [All Lists]

Re: [PATCH] Unify watch.S and remove arch/mips/lib-{32,64}

To: Atsushi Nemoto <>
Subject: Re: [PATCH] Unify watch.S and remove arch/mips/lib-{32,64}
From: Ralf Baechle <>
Date: Mon, 4 Jun 2007 16:10:48 +0100
In-reply-to: <>
Original-recipient: rfc822;
References: <>
User-agent: Mutt/1.5.14 (2007-02-12)
On Tue, Jun 05, 2007 at 12:02:39AM +0900, Atsushi Nemoto wrote:

> Unify lib-{32,64}/watch.S into lib/watch.S and remove lib-{32,64}
> completely.
> The old 64-bit __watch_set() expected an physical address and the old
> 32-bit __watch_set() expected a KSEG0 virtual address.  The new
> unified __watch_set() is based on the 64-bit one.  Since there is no
> real user of the __watch_set(), this incompatibility would not cause
> any problem.

I think we can simply drop the entire watchpoint support.  This was
only ever working on R4000/R4400 and even there only somewhat useful
for kernel debugging.  So if we ever use watchpoint support I think
something needs to be developed from scratch.


<Prev in Thread] Current Thread [Next in Thread>