[Top] [All Lists]

Re: [MIPS] Fix modpost warnings by making start_secondary __cpuinit

To: Atsushi Nemoto <>
Subject: Re: [MIPS] Fix modpost warnings by making start_secondary __cpuinit
From: Ralf Baechle <>
Date: Fri, 1 Jun 2007 18:40:21 +0100
In-reply-to: <>
Original-recipient: rfc822;
References: <S28573756AbXEaP7t/> <>
User-agent: Mutt/
On Sat, Jun 02, 2007 at 01:30:22AM +0900, Atsushi Nemoto wrote:

> Looking at arch/mips/kernel/smp.c, I suppose there should be much more
> functions to be marked as __cpuinit.  For example,
> prom_init_secondary(), prom_smp_finish(), prom_smp_finish(),
> prom_boot_secondary(), etc.
> And then, smtc_init_secondary(), smtc_smp_finish(), etc. ...

That is absolutely correct but beyond the minimal fix needed to deal with
the warning for 2.6.22.  Longer term I'd like to get CPU hotplugging
working, it could be a handy feature with multi-threaded kernel models such
as VSMP and SMTC.


<Prev in Thread] Current Thread [Next in Thread>