[Top] [All Lists]

Re: [PATCH] zs: Move to the serial subsystem

To: Andrew Morton <>
Subject: Re: [PATCH] zs: Move to the serial subsystem
From: Andy Whitcroft <>
Date: Wed, 30 May 2007 10:54:59 +0100
Cc: "Maciej W. Rozycki" <>,,,
In-reply-to: <>
Openpgp: url=
Original-recipient: rfc822;
References: <> <>
User-agent: Icedove (X11/20061220)
Andrew Morton wrote:
> On Tue, 29 May 2007 14:03:54 +0100 (BST) "Maciej W. Rozycki" 
> <> wrote:

> Hey, you have volatiles and didn't complain.  Andy, a
> reference to Documentation/volatile-considered-harmful.txt would suit.
> (That's

Added ...

Use of volatile is usually wrong: see
PATCH: XXX.eml:374:
FILE: linux-2.6.22-rc2/drivers/serial/zs.c:131:
+       volatile void __iomem *control = zport->port.membase +


I will batch up any changes to and send you them as a blob
when they get "interesting" if that suits.


<Prev in Thread] Current Thread [Next in Thread>